Skip to content

Revise Dcmission 4356 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2024
Merged

Revise Dcmission 4356 #248

merged 4 commits into from
Jul 11, 2024

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Jul 10, 2024

Purpose

  • incorporated best practices in the code and made it fit for the requirements of the Quick-Account-Setup

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[x] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

vipinvkmenon
vipinvkmenon reviewed Jul 10, 2024
View reviewed changes
@rui1610 rui1610 requested review from vipinvkmenon and removed request for vipinvkmenon and CHERIANS July 11, 2024 08:06
@rui1610 rui1610 merged commit bcb4de9 into main Jul 11, 2024
3 checks passed
@rui1610 rui1610 deleted the dcmission_4356 branch July 11, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipinvkmenon vipinvkmenon vipinvkmenon left review comments

@mahesh0431 mahesh0431 mahesh0431 approved these changes

@markusbalsam markusbalsam markusbalsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rui1610 @vipinvkmenon @mahesh0431 @markusbalsam